Skip to content

Commit

Permalink
Increase watcher in upgrade tests to timeout after 10m (#5270)
Browse files Browse the repository at this point in the history
Increase watcher in upgrade tests to timeout after 10m to catch any regressions for the agent upgrade watcher.
  • Loading branch information
michel-laterman authored Aug 19, 2024
1 parent adcfd51 commit 6b591eb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions .agent-versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"8.15.0-SNAPSHOT",
"8.14.4-SNAPSHOT",
"8.14.3",
"7.17.24-SNAPSHOT",
"7.17.23"
"7.17.24-SNAPSHOT"
]
}
6 changes: 3 additions & 3 deletions testing/upgradetest/upgrader.go
Original file line number Diff line number Diff line change
Expand Up @@ -382,11 +382,11 @@ func PerformUpgrade(
}

// it is unstable to continue until the watcher is done
// the maximum wait time is 1 minutes (2 minutes for grace) some older versions
// the maximum wait time is 10 minutes (12 minutes for grace) some older versions
// do not respect the `ConfigureFastWatcher` so we have to kill the watcher after the
// 1 minute window (1 min 15 seconds for grace) has passed.
// 10 minute window (10 min 15 seconds for grace) has passed.
logger.Logf("waiting for upgrade watcher to finish")
err = WaitForNoWatcher(ctx, 2*time.Minute, 10*time.Second, 1*time.Minute+15*time.Second)
err = WaitForNoWatcher(ctx, 12*time.Minute, 10*time.Second, 10*time.Minute+15*time.Second)
if err != nil {
return fmt.Errorf("watcher never stopped running: %w", err)
}
Expand Down

0 comments on commit 6b591eb

Please sign in to comment.