Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10](backport #3380) Fix when fixture.Install logs 'ignoring AGENT_KEEP_INSTALLED...' #3388

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 8, 2023

This is an automatic backport of pull request #3380 done by Mergify.
Cherry-pick of 3372e6f has failed:

On branch mergify/bp/8.10/pr-3380
Your branch is up to date with 'origin/8.10'.

You are currently cherry-picking commit 3372e6f8f1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pkg/testing/fixture_install.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner September 8, 2023 16:38
@mergify mergify bot removed the request for review from a team September 8, 2023 16:38
@mergify mergify bot added the backport label Sep 8, 2023
@mergify mergify bot requested a review from faec September 8, 2023 16:38
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Sep 8, 2023
@mergify mergify bot requested a review from pchila September 8, 2023 16:38
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-26T06:00:46.657+0000

  • Duration: 26 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 6277
Skipped 55
Total 6332

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor Author

mergify bot commented Sep 11, 2023

This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@AndersonQ AndersonQ force-pushed the mergify/bp/8.10/pr-3380 branch 2 times, most recently from fddf1d7 to ef84c44 Compare September 13, 2023 12:43
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.765% (80/81) 👍
Files 67.832% (194/286) 👍
Classes 66.48% (357/537) 👍
Methods 53.112% (1118/2105) 👍
Lines 38.596% (12712/32936) 👍 0.05
Conditionals 100.0% (0/0) 💚

@AndersonQ AndersonQ removed the conflicts There is a conflict in the backported pull request label Sep 13, 2023
@mergify
Copy link
Contributor Author

mergify bot commented Sep 13, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.10/pr-3380 upstream/mergify/bp/8.10/pr-3380
git merge upstream/8.10
git push upstream mergify/bp/8.10/pr-3380

@mergify
Copy link
Contributor Author

mergify bot commented Sep 18, 2023

This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏

@AndersonQ AndersonQ force-pushed the mergify/bp/8.10/pr-3380 branch from ef84c44 to 2081796 Compare September 18, 2023 13:43
@pierrehilbert
Copy link
Contributor

@AndersonQ could you please take care of it?

@mergify
Copy link
Contributor Author

mergify bot commented Sep 25, 2023

This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏

@AndersonQ AndersonQ force-pushed the mergify/bp/8.10/pr-3380 branch from 2081796 to 3584076 Compare September 26, 2023 06:00
@AndersonQ AndersonQ merged commit 5a033dd into 8.10 Sep 27, 2023
@AndersonQ AndersonQ deleted the mergify/bp/8.10/pr-3380 branch September 27, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants