Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.10](backport #3410) Fix TestInstallAndCLIUninstallWithEndpointSecurity integration test flakiness #3437

Merged
merged 2 commits into from
Sep 25, 2023
Merged

[8.10](backport #3410) Fix TestInstallAndCLIUninstallWithEndpointSecurity integration test flakiness #3437

merged 2 commits into from
Sep 25, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 18, 2023

This is an automatic backport of pull request #3410 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner September 18, 2023 17:19
@mergify mergify bot requested review from michalpristas and pchila and removed request for a team September 18, 2023 17:19
@mergify mergify bot added the backport label Sep 18, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-25T11:53:30.211+0000

  • Duration: 25 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 6277
Skipped 55
Total 6332

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 18, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.765% (80/81) 👍
Files 67.832% (194/286) 👍
Classes 66.48% (357/537) 👍
Methods 53.137% (1118/2104) 👍
Lines 38.682% (12722/32889) 👍 0.05
Conditionals 100.0% (0/0) 💚

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@ycombinator ycombinator enabled auto-merge (squash) September 19, 2023 17:01
@ycombinator ycombinator force-pushed the mergify/bp/8.10/pr-3410 branch from a3edd21 to 5f67aeb Compare September 19, 2023 17:05
@ycombinator
Copy link
Contributor

buildkite test this

@ycombinator
Fix TestInstallAndCLIUninstallWithEndpointSecurity integration test…
40b0dc1 
… flakiness (#3410)

* Return error if more than one Agent with same hostname is found in Fleet

* Fix make call

* Un-enroll Agent on test cleanup

* Use policy ID and hostname to uniquely find Agent

* Passing policy ID in more calls

* Fix implicit memory aliasing

* [Testing] Increasing timeout for status check to 10m

* Get Agent by ID

* Revert "Get Agent by ID"

This reverts commit 1c7da6e.

(cherry picked from commit b19e950)
@ycombinator ycombinator force-pushed the mergify/bp/8.10/pr-3410 branch from 5f67aeb to 40b0dc1 Compare September 20, 2023 17:17
@ycombinator
Copy link
Contributor

ycombinator commented Sep 20, 2023 •
edited
Loading

Progress: Thanks to #3447, the Buildkite build on this PR is now completing within a reasonable amount of time. Now it's failing with this error:

Error: error running test: ogc-linux-arm64-ubuntu-2204-e8cb unable to continue because stack never became ready: failed to check for cloud 8.10.2-SNAPSHOT to be ready: context deadline exceeded

... which should be mitigated once we backport #3441 to 8.10 #3448 is merged.

@mergify
Copy link
Contributor Author

mergify bot commented Sep 25, 2023

This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏

@ycombinator ycombinator merged commit d567304 into 8.10 Sep 25, 2023
@ycombinator ycombinator deleted the mergify/bp/8.10/pr-3410 branch September 25, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

@ycombinator ycombinator Awaiting requested review from ycombinator

Assignees

@ycombinator ycombinator

Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elasticmachine @ycombinator @pierrehilbert @michalpristas