Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10](backport #3431) Fix TestRemovePath flakiness on windows #3439

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2023

This is an automatic backport of pull request #3431 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Slightly modified the RemovePath retry loop on windows adding another iteration after deleting a blocking executable and introducing a small sleep between attempts.

(cherry picked from commit 995b85c)
@mergify mergify bot requested a review from a team as a code owner September 19, 2023 12:07
@mergify mergify bot requested review from AndersonQ and blakerouse and removed request for a team September 19, 2023 12:07
@mergify mergify bot added the backport label Sep 19, 2023
@mergify mergify bot assigned pchila Sep 19, 2023
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-19T12:07:44.287+0000

  • Duration: 26 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 6253
Skipped 55
Total 6308

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.765% (80/81) 👍
Files 67.719% (193/285) 👍
Classes 66.292% (354/534) 👍
Methods 53.079% (1112/2095) 👍
Lines 38.629% (12676/32815) 👎 -0.009
Conditionals 100.0% (0/0) 💚

@pchila
Copy link
Member

pchila commented Sep 22, 2023

buildkite test this

@mergify
Copy link
Contributor Author

mergify bot commented Sep 25, 2023

This pull request has not been merged yet. Could you please review and merge it @pchila? 🙏

@pchila
Copy link
Member

pchila commented Sep 25, 2023

buildkite test this

@pchila pchila merged commit d99f479 into 8.10 Sep 25, 2023
@pchila pchila deleted the mergify/bp/8.10/pr-3431 branch September 25, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants