Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Treat elastic-security container platforms as separate inputs #3460

Merged
merged 1 commit into from
Sep 22, 2023
Merged

[BUG] Treat elastic-security container platforms as separate inputs #3460

merged 1 commit into from
Sep 22, 2023

Conversation

norrietaylor
Copy link
Member

What does this PR do?

This PR modifies the elastic security spec file by treating the container platforms as separate inputs without the restriction of requiring the default install location.

Why is it important?

This fixes an issue where the beta deployment of Endpoint in K8s would throw an error on deployment.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

@norrietaylor norrietaylor added bug Something isn't working backport-v8.10.0 Automated backport with mergify labels Sep 21, 2023
@norrietaylor norrietaylor requested a review from a team as a code owner September 21, 2023 21:49
@norrietaylor norrietaylor force-pushed the norrietaylor/elastic-security-container-spec branch from 6fdbe8b to abd150c Compare September 21, 2023 21:50
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-22T02:23:25.174+0000

  • Duration: 28 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 6313
Skipped 59
Total 6372

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 21, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.78% (81/82) 👍
Files 66.102% (195/295) 👍
Classes 65.693% (360/548) 👍
Methods 52.769% (1134/2149) 👍
Lines 38.242% (12872/33659) 👍 0.027
Conditionals 100.0% (0/0) 💚

blakerouse
blakerouse reviewed Sep 21, 2023
View reviewed changes
specs/endpoint-security.spec.yml Outdated Show resolved Hide resolved
specs/endpoint-security.spec.yml Outdated Show resolved Hide resolved
specs/endpoint-security.spec.yml Outdated Show resolved Hide resolved
@norrietaylor norrietaylor force-pushed the norrietaylor/elastic-security-container-spec branch from abd150c to 282359b Compare September 22, 2023 02:23
@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

blakerouse
blakerouse approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes.

@norrietaylor norrietaylor merged commit 698f7b9 into main Sep 22, 2023
11 checks passed
@norrietaylor norrietaylor deleted the norrietaylor/elastic-security-container-spec branch September 22, 2023 15:06
mergify bot pushed a commit that referenced this pull request Sep 22, 2023
@norrietaylor @mergify
Treat elastic-security container platforms as separate inputs (#3460)
1798721 
(cherry picked from commit 698f7b9)
@mergify mergify bot mentioned this pull request Sep 22, 2023
Merged
norrietaylor added a commit that referenced this pull request Sep 25, 2023
@mergify @norrietaylor
Treat elastic-security container platforms as separate inputs (#3460) (…
c022f06 
…#3466)

(cherry picked from commit 698f7b9)

Co-authored-by: Norrie Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz

@nicholasberlin nicholasberlin Awaiting requested review from nicholasberlin

@nick-alayil nick-alayil Awaiting requested review from nick-alayil

@nfritts nfritts Awaiting requested review from nfritts

Assignees

@norrietaylor norrietaylor

Labels
backport-v8.10.0 Automated backport with mergify bug Something isn't working skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norrietaylor @elasticmachine @blakerouse