Refactor agent version pinning in integration test script #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchila
added
Team:Elastic-Agent
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
pchila
requested review from
michalpristas and
blakerouse
and removed request for
a team
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
buildkite test this |
cmacknz
reviewed
Sep 25, 2023
|
|
||
| # Run integration tests | ||
| set +e | ||
| # Use 8.10.2-SNAPSHOT until the first 8.10.3-SNAPSHOT is produced. | ||
| AGENT_VERSION="8.10.2-SNAPSHOT" TEST_INTEG_AUTH_ESS_REGION=azure-eastus2 TEST_INTEG_CLEAN_ON_EXIT=true SNAPSHOT=true mage integration:test | ||
| AGENT_VERSION="${OVERRIDE_TEST_AGENT_VERSION}" TEST_INTEG_AUTH_ESS_REGION=azure-eastus2 TEST_INTEG_CLEAN_ON_EXIT=true SNAPSHOT=true mage integration:test |
There was a problem hiding this comment.
The comment above this can be removed since it references 8.10.2 and 8.10.3 where that isn't relevant anymore.
michalpristas
approved these changes
Sep 26, 2023
cmacknz
approved these changes
Sep 26, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Refactor agent version pinning in integration test script * remove 8.10.2 version pinning (cherry picked from commit a7b2514) # Conflicts: # .buildkite/scripts/steps/integration_tests.sh
pchila
added a commit
that referenced
this pull request
Sep 27, 2023
…test script (#3476) * Refactor agent version pinning in integration test script * remove 8.10.2 version pinning (cherry picked from commit a7b2514) # Conflicts: # .buildkite/scripts/steps/integration_tests.sh * resolve cherry-pick conflicts --------- Co-authored-by: Paolo Chilà <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove override on agent and stack version
Why is it important?
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Questions to ask yourself