-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un-hide --base-path
install flag
#3517
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
I would backport this to 8.11 since it is just making the help text visible, the feature is already present and tested. |
🌐 Coverage report
|
51ac35b
to
40ef6ff
Compare
40ef6ff
to
99732b9
Compare
SonarQube Quality Gate |
(cherry picked from commit 0ba1a44)
(cherry picked from commit 0ba1a44) Co-authored-by: Shaunak Kashyap <[email protected]>
@kilfoyle would you happen to have a doc issue for this already? thx |
@nimarezainia The v8.11 and higher version docs were updated just recently via elastic/ingest-docs#532 to show the |
@ycombinator I notice that the install command docs haven't been updated to include the |
Yes, good catch — thank you!
That's correct. |
What does this PR do?
This PR un-hides the
--base-path
flag defined on theelastic-agent install
sub-command.Why is it important?
To allow users to install Elastic Agent in custom locations.
Checklist
I have made corresponding changes to the documentationSee Re-add docs for install '--base-path' parameter ingest-docs#532I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksAlready covered by Allow users to specify base path withelastic-agent install
#2500I have added an entry inAlready covered by Allow users to specify base path with./changelog/fragments
using the changelog toolelastic-agent install
#2500I have added an integration test or an E2E testAlready covered by Add integration test for Agent installation #2578