Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-hide --base-path install flag #3517

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

This PR un-hides the --base-path flag defined on the elastic-agent install sub-command.

Why is it important?

To allow users to install Elastic Agent in custom locations.

Checklist

@ycombinator ycombinator requested a review from a team as a code owner October 4, 2023 15:32
@ycombinator ycombinator requested review from faec and pchila October 4, 2023 15:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@cmacknz
Copy link
Member

cmacknz commented Oct 4, 2023

I would backport this to 8.11 since it is just making the help text visible, the feature is already present and tested.

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-04T21:38:05.749+0000

  • Duration: 26 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 6425
Skipped 59
Total 6484

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.78% (81/82) 👍
Files 65.667% (197/300) 👍
Classes 64.991% (362/557) 👍
Methods 52.311% (1143/2185) 👍
Lines 37.973% (13010/34261) 👎 -0.031
Conditionals 100.0% (0/0) 💚

@mergify mergify bot removed the backport-skip label Oct 4, 2023
@ycombinator ycombinator force-pushed the unhide-install-base-path branch from 51ac35b to 40ef6ff Compare October 4, 2023 17:35
@cmacknz cmacknz added backport-v8.11.0 Automated backport with mergify and removed backport-v8.11.0 Automated backport with mergify labels Oct 4, 2023
@ycombinator ycombinator force-pushed the unhide-install-base-path branch from 40ef6ff to 99732b9 Compare October 4, 2023 21:37
@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ycombinator ycombinator merged commit 0ba1a44 into elastic:main Oct 5, 2023
@ycombinator ycombinator deleted the unhide-install-base-path branch October 5, 2023 01:00
mergify bot pushed a commit that referenced this pull request Oct 5, 2023
(cherry picked from commit 0ba1a44)
ycombinator added a commit that referenced this pull request Oct 5, 2023
(cherry picked from commit 0ba1a44)

Co-authored-by: Shaunak Kashyap <[email protected]>
@nimarezainia
Copy link
Contributor

@kilfoyle would you happen to have a doc issue for this already? thx

@kilfoyle
Copy link
Contributor

would you happen to have a doc issue for this already? thx

@nimarezainia The v8.11 and higher version docs were updated just recently via elastic/ingest-docs#532 to show the --base-path option. I'll add a note to the support issue.

@kilfoyle
Copy link
Contributor

@ycombinator I notice that the install command docs haven't been updated to include the --base-path option. I can open up a PR to fix that. Am I correct to understand that the option is available for the install command and not the enroll command?

@ycombinator
Copy link
Contributor Author

@ycombinator I notice that the install command docs haven't been updated to include the --base-path option. I can open up a PR to fix that.

Yes, good catch — thank you!

Am I correct to understand that the option is available for the install command and not the enroll command?

That's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.11.0 Automated backport with mergify skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants