Avoid data race by calling forceCompState only on commandRuntime.Run #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
added
bug
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Instead of using the component state to show the error, log it using the component stderr logger
AndersonQ
force-pushed
the
3512-commandruntime-data-race
branch
2 times, most recently
from
8e330cb to
7a08cb1
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
blakerouse
approved these changes
Oct 5, 2023
| kind: bug | ||
|
|
||
| # Change summary; a 80ish characters long description of the change. | ||
| summary: Avoid possible data race when diring a component start the Elastic Agent fails to write to the component's stdin |
There was a problem hiding this comment.
Do we need a changelog entry? Has this actually ever effected a user in a meaningful way?
🌐 Coverage report
|
|
buildkite test this |
1 similar comment
|
buildkite test this |
|
SonarQube Quality Gate
|
AndersonQ
added a commit
that referenced
this pull request
Oct 6, 2023
…ime.Run (#3537) (#3555) Instead of startWatcher setting the component state on comm.WriteConnInfo failure, now it logs the error using the component stderr logger. (cherry picked from commit 39f324f) Co-authored-by: Anderson Queiroz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of using the component state to show the error, log it using the component stderr logger
Why is it important?
If
forceCompStateis called outside(*commandRuntime).Runit creates a data race.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testRelated issues
Questions to ask yourself