-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning messages to magefile for version mismatches in beats #3580
Add warning messages to magefile for version mismatches in beats #3580
Conversation
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
NOTE: |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however I would make that an error and interrupt the packaging process.
I've shoot myself in the foot because of this as well. If we need mismatched versions for testing/development, we know what we're doing and we can just modify the version files.
As a general behaviour I rather error on the safe side and not generate an inconsistent package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments but overall LGTM!
Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: Shaunak Kashyap <[email protected]>
Co-authored-by: Shaunak Kashyap <[email protected]>
SonarQube Quality Gate |
What does this PR do?
This adds a few warning lines to the magefile to handle cases where there's a version mismatch between the agent repo and the beat repo. Shot myself in the foot a few times with this, so it will just quit if it detects a version mismatch.
Checklist