Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the GPG FS verifier warn message #3585

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix typo in the GPG FS verifier warn message #3585

merged 1 commit into from
Oct 12, 2023

Conversation

pierrehilbert
Copy link
Contributor

What does this PR do?

Replace succfailed by failed.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pierrehilbert pierrehilbert requested a review from a team as a code owner October 11, 2023 14:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

This pull request does not have a backport label. Could you fix it @pierrehilbert? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-11T14:10:48.823+0000

  • Duration: 30 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 6525
Skipped 59
Total 6584

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.795% (82/83) 👍
Files 67.114% (200/298) 👍
Classes 65.766% (365/555) 👍
Methods 53.033% (1154/2176) 👍
Lines 38.617% (13180/34130) 👍 0.012
Conditionals 100.0% (0/0) 💚

@pierrehilbert
Copy link
Contributor Author

buildkite test this

@elastic-sonarqube
Copy link

@pierrehilbert pierrehilbert merged commit 359be4f into main Oct 12, 2023
14 checks passed
@pierrehilbert pierrehilbert deleted the gpg-typo branch October 12, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants