Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/elastic/elastic-agent-autodiscover from 0.6.3 to 0.6.4 #3588

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 11, 2023

Bumps github.com/elastic/elastic-agent-autodiscover from 0.6.3 to 0.6.4.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/elastic/elastic-agent-autodiscover](https://github.com/elastic/elastic-agent-autodiscover) from 0.6.3 to 0.6.4.
- [Release notes](https://github.com/elastic/elastic-agent-autodiscover/releases)
- [Changelog](https://github.com/elastic/elastic-agent-autodiscover/blob/main/CHANGELOG.md)
- [Commits](elastic/elastic-agent-autodiscover@v0.6.3...v0.6.4)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-agent-autodiscover
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner October 11, 2023 22:00
@dependabot dependabot bot requested review from blakerouse and pchila October 11, 2023 22:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

This pull request does not have a backport label. Could you fix it @dependabot[bot]? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-11T22:02:12.929+0000

  • Duration: 28 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 6489
Skipped 59
Total 6548

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.78% (81/82) 👍
Files 67.003% (199/297) 👍
Classes 65.642% (363/553) 👍
Methods 52.974% (1149/2169) 👍
Lines 38.581% (13135/34045) 👎 -0.003
Conditionals 100.0% (0/0) 💚

@pierrehilbert pierrehilbert merged commit 539bef4 into main Oct 12, 2023
3 checks passed
@pierrehilbert pierrehilbert deleted the dependabot/go_modules/github.com/elastic/elastic-agent-autodiscover-0.6.4 branch October 12, 2023 06:31
@cmacknz
Copy link
Member

cmacknz commented Oct 12, 2023

@pierrehilbert this contains a breaking change to autodiscover, it needs the changelog fragment from #3591 (review). Possibly just forward porting that PR to main once it merges will do it.

@pierrehilbert
Copy link
Contributor

Correct me if I'm wrong here but because we will have the changelog in 8.10.X and main is for 8.12, we won't need to have the fragment on main "even if it would have been cleaner" as this will be removed and we will get it in the 8.10.X consolidated changelog

@cmacknz
Copy link
Member

cmacknz commented Oct 12, 2023

👍 yes you are correct, I am used to seeing the changes go to main first but this is fine as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants