Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable log errors check test and filter for acceptable errors #3616

Merged
merged 8 commits into from
Oct 19, 2023
Merged

Enable log errors check test and filter for acceptable errors #3616

merged 8 commits into from
Oct 19, 2023

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Oct 17, 2023 •
edited
Loading

This PR decreases some of the log levels from error to warning.
Also adds a filter in a test for errors not coming from agent which are somehow expected/acceptable in a process.

Fixes: #3562

@michalpristas michalpristas added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team flaky-test Unstable or unreliable test cases. labels Oct 17, 2023
@michalpristas michalpristas self-assigned this Oct 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

This pull request does not have a backport label. Could you fix it @michalpristas? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@michalpristas michalpristas added skip-changelog backport-v8.11.0 Automated backport with mergify and removed backport-skip labels Oct 17, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-17T14:10:56.724+0000

  • Duration: 26 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 6501
Skipped 59
Total 6560

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 17, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.81% (83/84) 👍
Files 67.105% (204/304) 👍
Classes 65.719% (370/563) 👍
Methods 53.043% (1168/2202) 👍
Lines 39.353% (13639/34658) 👍 0.012
Conditionals 100.0% (0/0) 💚

@michalpristas michalpristas marked this pull request as ready for review October 17, 2023 11:46
@michalpristas michalpristas requested a review from a team as a code owner October 17, 2023 11:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

42.9% 42.9% Coverage
0.0% 0.0% Duplication

blakerouse
blakerouse approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michalpristas michalpristas merged commit 96d46f9 into elastic:main Oct 19, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Oct 19, 2023
@michalpristas @mergify
Enable log errors check test and filter for acceptable errors (#3616)
be7233b 
(cherry picked from commit 96d46f9)
@mergify mergify bot mentioned this pull request Oct 19, 2023
Merged
@cmacknz cmacknz mentioned this pull request Oct 19, 2023
Merged
7 tasks
michalpristas added a commit that referenced this pull request Oct 23, 2023
@mergify @michalpristas
Enable log errors check test and filter for acceptable errors (#3616) (…
e2ffe2b 
…#3637)

(cherry picked from commit 96d46f9)

Co-authored-by: Michal Pristas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@michalpristas michalpristas

Labels
backport-v8.11.0 Automated backport with mergify bug Something isn't working flaky-test Unstable or unreliable test cases. skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore the test assertion that agent monitoring logs should not contain errors
3 participants
@michalpristas @elasticmachine @blakerouse