Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Custom Ingest pipeline for k8s integration to enrich deployment and cronjob names #3618

Closed
wants to merge 5 commits into from

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Oct 17, 2023

  • Docs

What does this PR do?

WHAT: Adds doc example for ingest pipeline needed for metadata enrichment for deployments and cronjobs
WHY: Needed as an alternative to allow users enrich their kubernetes pods now that we have backported #3591

Why is it important?

It is needed because users will probably miss wanted deployment and cronjob fields in their deployments

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

Screenshots

discovery_with_k8s_ingest_pipeline

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

This pull request does not have a backport label. Could you fix it @gizas? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-17T10:29:23.584+0000

  • Duration: 29 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 6501
Skipped 59
Total 6560

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 17, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.81% (83/84) 👍
Files 67.105% (204/304) 👍
Classes 65.719% (370/563) 👍
Methods 53.043% (1168/2202) 👍 0.045
Lines 39.339% (13634/34658) 👍 0.05
Conditionals 100.0% (0/0) 💚

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Oct 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@gizas
Copy link
Contributor Author

gizas commented Oct 24, 2023

@elastic/elastic-agent-control-plane could you have a look here please?

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could this documentation live with the integration itself or as part of the official agent and fleet documentation https://github.com/elastic/ingest-docs/tree/main/docs/en/ingest-management instead?

Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I agree with @cmacknz that this should live in the integration or Agent and Fleet documentation (that is where users are most likely to look for it, rather than the agent git repository?

@gizas
Copy link
Contributor Author

gizas commented Oct 30, 2023

Thank you guys I move the relevant PR here elastic/ingest-docs#630. Closing this as duplicate

@gizas gizas closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants