-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc Custom Ingest pipeline for k8s integration to enrich deployment and cronjob names #3618
Conversation
This pull request does not have a backport label. Could you fix it @gizas? 🙏
NOTE: |
🌐 Coverage report
|
SonarQube Quality Gate |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
@elastic/elastic-agent-control-plane could you have a look here please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but could this documentation live with the integration itself or as part of the official agent and fleet documentation https://github.com/elastic/ingest-docs/tree/main/docs/en/ingest-management instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however I agree with @cmacknz that this should live in the integration or Agent and Fleet documentation (that is where users are most likely to look for it, rather than the agent git repository?
Thank you guys I move the relevant PR here elastic/ingest-docs#630. Closing this as duplicate |
What does this PR do?
WHAT: Adds doc example for ingest pipeline needed for metadata enrichment for deployments and cronjobs
WHY: Needed as an alternative to allow users enrich their kubernetes pods now that we have backported #3591
Why is it important?
It is needed because users will probably miss wanted deployment and cronjob fields in their deployments
Checklist
./changelog/fragments
using the changelog toolRelated issues
Screenshots