-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component.{id, binary} to monitoring metrics #3626
Conversation
This pull request does not have a backport label. Could you fix it @belimawr? 🙏
NOTE: |
🌐 Coverage report
|
ff20b95
to
9b230de
Compare
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should backport to v8.11 as this is part of the bug fix for duplicated TSDB documents in the elastic agent integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good!
This commit adds `component.id` and `component.binary` to the monitoring metrics, those fields are necessary to create unique TSDB entries.
39ebf3d
to
5070bef
Compare
SonarQube Quality Gate |
This commit adds `component.id` and `component.binary` to the monitoring metrics, those fields are necessary to create unique TSDB entries. (cherry picked from commit c4462d2)
This commit adds `component.id` and `component.binary` to the monitoring metrics, those fields are necessary to create unique TSDB entries. (cherry picked from commit c4462d2) Co-authored-by: Tiago Queiroz <[email protected]>
What does this PR do?
This PR adds
component.id
andcomponent.binary
to the monitoring metrics, those fields are necessary to create unique TSDB entries.Why is it important?
It fixes metrics collection.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works./changelog/fragments
using the changelog tool- [ ] I have added an integration test or an E2E testAuthor's Checklist
How to test this PR locally
See the "How to test this PR locally" section from the integrations PR: elastic/integrations#8238
Related issues
## Use cases## Screenshots## LogsQuestions to ask yourself