Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "install fails if enroll fails and surface errors" #3629

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

AndersonQ
Copy link
Member

@AndersonQ AndersonQ added the Team:Elastic-Agent Label for the Agent team label Oct 18, 2023
@AndersonQ AndersonQ requested a review from cmacknz October 18, 2023 17:09
@AndersonQ AndersonQ self-assigned this Oct 18, 2023
@AndersonQ AndersonQ requested a review from a team as a code owner October 18, 2023 17:09
@AndersonQ AndersonQ requested a review from pchila October 18, 2023 17:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023

This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 26.1% 26.1% Coverage on New Code (is less than 40%)

See analysis details on SonarQube

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-18T17:09:17.052+0000

  • Duration: 27 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 6501
Skipped 59
Total 6560

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.81% (83/84) 👍
Files 67.105% (204/304) 👍
Classes 65.719% (370/563) 👍
Methods 52.997% (1167/2202) 👎 -0.045
Lines 39.306% (13610/34626) 👎 -0.056
Conditionals 100.0% (0/0) 💚

@cmacknz
Copy link
Member

cmacknz commented Oct 18, 2023

Force merging, ignoring the SonarQube failure on the revert commit which we shouldn't be modifying from the original.

@cmacknz cmacknz merged commit 1fd44fe into main Oct 18, 2023
7 of 11 checks passed
@cmacknz cmacknz deleted the revert-3554-fail-enroll branch October 18, 2023 19:21
AndersonQ added a commit to AndersonQ/elastic-agent that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants