Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade elastic-agent-libs to v0.6.0 #3632

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Oct 18, 2023

What does this PR do?

upgrade elastic-agent-libs to v0.6.0

allows elastic-agent running as a windows service to receive more than one
change request. Without this elastic-agent can become unresponsive to
Windows Service Manager requests (Interrogate/Shutdown/Restart).

Why is it important?

Without this change Restart and Uninstall may hang, and shutdowns take significantly longer.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

  1. Install elastic-agent as a Windows Service, stand alone or Fleet managed
  2. Start PowerShell
  3. Interrogate service with 3 calls to Get-WmiObject -Class Win32_Service -Filter "name='Elastic Agent'"
  4. Try to Restart 'Elastic Agent' with Services control panel

Without this PR Restart should fail, with PR it should succeed

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

allows elastic-agent running as a windows service to receive more than
one change request.
@leehinman leehinman requested a review from a team as a code owner October 18, 2023 20:47
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023

This pull request does not have a backport label. Could you fix it @leehinman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@leehinman leehinman added bug Something isn't working Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-v8.11.0 Automated backport with mergify labels Oct 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mergify mergify bot removed the backport-skip label Oct 18, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-18T20:50:55.348+0000

  • Duration: 25 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 6501
Skipped 59
Total 6560

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.81% (83/84) 👍
Files 67.105% (204/304) 👍
Classes 65.719% (370/563) 👍
Methods 52.997% (1167/2202) 👍
Lines 39.265% (13596/34626) 👍 0.003
Conditionals 100.0% (0/0) 💚

@leehinman leehinman merged commit 3c2f61a into elastic:main Oct 19, 2023
12 checks passed
mergify bot pushed a commit that referenced this pull request Oct 19, 2023
* upgrade elastic-agent-libs to v0.6.0

allows elastic-agent running as a windows service to receive more than
one change request.

(cherry picked from commit 3c2f61a)

# Conflicts:
#	go.mod
#	go.sum
@leehinman leehinman deleted the wmi_fix branch October 19, 2023 00:53
leehinman added a commit that referenced this pull request Oct 19, 2023
* upgrade elastic-agent-libs to v0.6.0 (#3632)

* upgrade elastic-agent-libs to v0.6.0

allows elastic-agent running as a windows service to receive more than
one change request.

(cherry picked from commit 3c2f61a)

# Conflicts:
#	go.mod
#	go.sum

* resolve conflicts

---------

Co-authored-by: Lee E Hinman <[email protected]>
Co-authored-by: Lee E. Hinman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.11.0 Automated backport with mergify bug Something isn't working Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
3 participants