-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable exposing metrics server on all interfaces #3662
Disable exposing metrics server on all interfaces #3662
Conversation
🌐 Coverage report
|
SonarQube Quality Gate |
ci failing on processing failed results 🤦 |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
I re-ran the processing step that seems to be okay this time |
http: | ||
enabled: true | ||
host: " "`, DefaultHost}, | ||
{"default", `enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion]
{"default", `enabled: true | |
{"default host", `enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR disables option to configure agent in a way that it will expose monitoring agent on all interfaces. Empty value for agent.monitoring.http.host is now disabled and is replaced by localhost Agents upgraded from <8.5 do have empty host due to change in defaults in 8.5. These agents are exposing metrics endpoint on all interfaces not on purpose. Guard is implemented at the time of configuration unpacking and at the time of server creation to minimize future misbehavior with possible code changes (cherry picked from commit 2afea75)
This PR disables option to configure agent in a way that it will expose monitoring agent on all interfaces. Empty value for agent.monitoring.http.host is now disabled and is replaced by localhost Agents upgraded from <8.5 do have empty host due to change in defaults in 8.5. These agents are exposing metrics endpoint on all interfaces not on purpose. Guard is implemented at the time of configuration unpacking and at the time of server creation to minimize future misbehavior with possible code changes (cherry picked from commit 2afea75) Co-authored-by: Michal Pristas <[email protected]>
What does this PR do?
This PR disables option to configure agent in a way that it will expose monitoring agent on all interfaces.
Empty value for
agent.monitoring.http.host
is now disabled and is replaced by localhostAgents upgraded from <8.5 do have empty host due to change in defaults in 8.5. These agents are exposing metrics endpoint on all interfaces not on purpose.
Guard is implemented at the time of configuration unpacking and at the time of server creation to minimize future misbehavior with possible code changes
Fixes: #2509