Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11](backport #3657) Increase the Windows OnFailureDelayDuration delay to 15s #3665

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 26, 2023

This is an automatic backport of pull request #3657 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Update Windows OnFailureDelayDuration to 15s.

This matches the value that endpoint uses and helps mitigate bugs where
agent unexpectedly restarts during a system shutdown.

* Add changelog.

* Update changelog/fragments/1698259940-Increase-wait-period-between-service-restarts-on-failure-to-15s-on-Windows.yaml

Co-authored-by: Paolo Chilà <[email protected]>

---------

Co-authored-by: Paolo Chilà <[email protected]>
(cherry picked from commit 910d17b)
@mergify mergify bot requested a review from a team as a code owner October 26, 2023 20:44
@mergify mergify bot requested review from michalpristas and pchila and removed request for a team October 26, 2023 20:44
@mergify mergify bot added the backport label Oct 26, 2023
@elastic-sonarqube
Copy link

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-26T20:44:26.408+0000

  • Duration: 27 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 6477
Skipped 59
Total 6536

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.81% (83/84) 👍
Files 66.556% (201/302) 👍
Classes 65.357% (366/560) 👍
Methods 52.847% (1160/2195) 👍
Lines 39.158% (13518/34522) 👎 -0.003
Conditionals 100.0% (0/0) 💚

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Oct 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@pierrehilbert pierrehilbert requested review from cmacknz and removed request for michalpristas and pchila October 27, 2023 06:14
@cmacknz
Copy link
Member

cmacknz commented Oct 27, 2023

Test failure is unrelated (it's on Linux), merging

@cmacknz cmacknz merged commit c1de297 into 8.11 Oct 27, 2023
10 checks passed
@cmacknz cmacknz deleted the mergify/bp/8.11/pr-3657 branch October 27, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants