-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "add a DEB integration test" #4419
Conversation
This reverts commit 4fd31f1.
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Fix is easy. Line 23 in
it adds the deb & rpm packages. My question is why did we pass all the tests when #4301 was merged? |
The next daily build passed https://buildkite.com/elastic/elastic-agent/builds/7791 |
@leehinman we run serverless tests only on daily builds, therefore it was not caught before. |
Well I opened up #4424 to restore this, with the potential fix. But given that the serverless tests won't run, do we just merge and hope for the best? @pierrehilbert @jlind23 this seems like a gap we will want to close in the near future. |
@leehinman one can temporarily set the elastic-agent/.buildkite/pipeline.yml Line 249 in a7034ef
|
You could also just run the script the beats tests use to check that you can past the broken step manually: elastic-agent/.buildkite/scripts/steps/beats_tests.sh Lines 14 to 36 in a7034ef
|
Reverts #4301
The Serverless Beats Tests step in our daily builds started failing with:
The last successful build is https://buildkite.com/elastic/elastic-agent/builds/7707
The first failure is https://buildkite.com/elastic/elastic-agent/builds/7735
There were only 2 changes made between these, this change is one of them. Let's try to revert this first because it has the least impact.