Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update elastic-agent-logging.md with right calculation details for disk sizing #4483

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

e-parth-pathak
Copy link
Contributor

While researching for a case I noticed that there might have been a typo mistake here where the calculation of the default disk size required for the Elastic Agent's log files was explained.

What does this PR do?

  • The calculation of the amount of disk had a small mistake on line 70.
  • It should be:
(20Mb x 7 + 10Mb x 7 = 210Mb)

Why is it important?

Right calculation of the defaults would be necessary to set the right expectations.

The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```
Copy link
Contributor

mergify bot commented Mar 26, 2024

This pull request does not have a backport label. Could you fix it @e-parth-pathak? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@lucabelluccini lucabelluccini added backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify backport-v8.9.0 Automated backport with mergify backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify and removed backport-skip labels Mar 26, 2024
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@jlind23
Copy link
Contributor

jlind23 commented Oct 7, 2024

No build nor sonar check are required hence merging this.

@jlind23 jlind23 merged commit 1eb5e12 into main Oct 7, 2024
8 checks passed
@jlind23 jlind23 deleted the e-parth-pathak-patch-1 branch October 7, 2024 16:47
@jlind23 jlind23 removed backport-v8.6.0 Automated backport with mergify backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify backport-v8.9.0 Automated backport with mergify backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify labels Oct 7, 2024
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)

# Conflicts:
#	docs/elastic-agent-logging.md
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)

# Conflicts:
#	docs/elastic-agent-logging.md
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)

# Conflicts:
#	docs/elastic-agent-logging.md
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)

# Conflicts:
#	docs/elastic-agent-logging.md
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)

# Conflicts:
#	docs/elastic-agent-logging.md
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)

# Conflicts:
#	docs/elastic-agent-logging.md
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)

# Conflicts:
#	docs/elastic-agent-logging.md
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)

# Conflicts:
#	docs/elastic-agent-logging.md
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)
jlind23 pushed a commit that referenced this pull request Oct 7, 2024
The calculation of the amount of disk had a small mistake on line 70. Changed:

```
210Mb (20Mb x 7 + 10Mb x 7 = 210Mb)
```

Co-authored-by: Pierre HILBERT <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 1eb5e12)

Co-authored-by: Parth Pathak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants