Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPM integration tests #4498

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Second attempt at adding RPM integration tests.

Previous attempt #4461 was reverted because SLES platform was failing due to a race condition where the rpm repositories were removed. This PR switches the tests to RHEL, and adds additional SSH logging to make it easier to identify events like this. TCP keepalives were also added to SSH connections to better detect network outages.

Why is it important?

Need to test RPM builds

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

mage integration:single TestRpmLogIngestFleetManaged

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

Copy link
Contributor

mergify bot commented Mar 28, 2024

This pull request does not have a backport label. Could you fix it @leehinman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Mar 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

pkg/testing/runner/sles.go Outdated Show resolved Hide resolved
pkg/testing/runner/ssh.go Show resolved Hide resolved
pkg/testing/runner/ssh.go Show resolved Hide resolved
pkg/testing/runner/supported.go Outdated Show resolved Hide resolved
- add sles runner
- add rhel runner
- add test that uses rhel runner
- add logging to ssh
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@leehinman leehinman merged commit 6f95873 into elastic:main Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants