Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix log message when settings log level from SETTINGS action #4751

Merged
merged 1 commit into from
May 16, 2024
Merged

fix log message when settings log level from SETTINGS action #4751

merged 1 commit into from
May 16, 2024

Conversation

nchaulet
Copy link
Member

Description

Resolve #4749

Fix log message when setting log level from settings action to display the log level we are setting from action, policy or default one.

@nchaulet nchaulet added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels May 14, 2024
@nchaulet nchaulet requested a review from a team as a code owner May 14, 2024 20:42
@nchaulet nchaulet requested review from rdner and faec May 14, 2024 20:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024

This pull request does not have a backport label. Could you fix it @nchaulet? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

blakerouse
blakerouse approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nchaulet nchaulet merged commit b4b3051 into main May 16, 2024
9 of 13 checks passed
@nchaulet nchaulet deleted the fix-log-log-level-settings branch May 16, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-control-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@nchaulet nchaulet

Labels
backport-skip enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better log message for resetting log level
3 participants
@nchaulet @elasticmachine @blakerouse