Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14](backport #4836) [CI] Trigger improvements #4845

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 4, 2024

What does this PR do?

Draft PRs will not run integration tests. If you need to run them use /test extended trigger comment.
Introducing skip-ci and skip-it labels.
Makes buildkite pull request builds to ignore .ci and .github directories.
Also all *.md files
Made file patterns more strict by adding ^
Added CI cheatsheet to pull request template

Why is it important?

Integration tests were executed

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #4836 done by [Mergify](https://mergify.com).

* [CI] Added .github and .ci directories to skip_ci_on_only_changed

* [CI] Removed sonar-project.properties from ignored PR changesets

* [CI] skip labels and CI cheatsheet

* Added alternative triggers description

(cherry picked from commit 0b99ccb)

# Conflicts:
#	.buildkite/pull-requests.json
@mergify mergify bot requested a review from a team as a code owner June 4, 2024 14:40
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jun 4, 2024
@mergify mergify bot requested review from kaanyalti and michel-laterman and removed request for a team June 4, 2024 14:40
@mergify mergify bot assigned pazone Jun 4, 2024
Copy link
Contributor Author

mergify bot commented Jun 4, 2024

Cherry-pick of 0b99ccb has failed:

On branch mergify/bp/8.14/pr-4836
Your branch is up to date with 'origin/8.14'.

You are currently cherry-picking commit 0b99ccb922.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/PULL_REQUEST_TEMPLATE.md

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/pull-requests.json

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor Author

mergify bot commented Jun 10, 2024

This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏

@pierrehilbert
Copy link
Contributor

@pazone what is the expected timeline with this PR?

@pazone
Copy link
Contributor

pazone commented Jun 11, 2024

I think it must be closed in favour to another PR

@pazone pazone closed this Jun 11, 2024
@mergify mergify bot deleted the mergify/bp/8.14/pr-4836 branch June 11, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request Team:Ingest-EngProd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants