-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ind Agent] Update packaging to properly package from manifest if given #4885
Merged
Merged
Changes from 6 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
7a0913e
Download from manifest if version has +1 patch
dwhyrock e7d6a3e
Try modified globExpr
dwhyrock 41fe9fb
use version package
dwhyrock 9f1af73
catch err
dwhyrock 1fad3b2
use panic
dwhyrock 18456a9
Add the filepath
dwhyrock ac0f535
better package finding
dwhyrock 5c13998
more intermediate work
dwhyrock 9b0a181
more progress
dwhyrock bacda1f
it seems to maybe work
dwhyrock 49a9dfc
fixed bug
dwhyrock 8c9e21a
Copying spec files as well
dwhyrock 2f05b52
temp test value
dwhyrock 4f827be
fixing linting errors
dwhyrock 01ead7e
Merge branch 'main' into ind-agent-fix-package-endpoint-next-version
dwhyrock 3d9f4ca
Clean up manifest code
dwhyrock 48c65c3
Cleaning up
dwhyrock 5f1ab42
Cleanup 2
dwhyrock 619512d
removing test variable
dwhyrock 9afa054
addressing PR comments and cleanup
dwhyrock 36c2fac
Adding manifest tests
dwhyrock 5f11a2b
Update magefile.go
dwhyrock 8d9bd37
Merge branch 'main' into ind-agent-fix-package-endpoint-next-version
pierrehilbert 799ed15
Switch to go:embed for tests.
cmacknz 4fd3c50
Build component specs from external binaries.
cmacknz ff3d84a
Convert component to project in var names
cmacknz 6a8c4ae
Return error when package not found.
cmacknz 9fd0ffa
Filter unsupported platforms.
cmacknz 9eda0ac
Fix darwin/arm64 build.
cmacknz 026ece7
Several renames for consistency.
cmacknz ab3ecae
A few more renames.
cmacknz b4ce8c7
Move code out of magefile
cmacknz 11404b1
mage fmt
cmacknz 539d648
Fix log message.
cmacknz c495c94
Fix lint warnings.
cmacknz 03e64b1
Rename test.
cmacknz 7754ffd
Refactor to share download from manifest logic.
cmacknz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why the input manifest can't specify the patch+1 version? That would keep the logic for this in the release jobs, with the agent package target just doing what the manifest tells it to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that may be a decent way to go.
I think the way it works is that it uses the
version
value in the header, which is something like8.13.4+build202406101001
. And then we strip off the metadata to get the base 3-number version for the previously-released (opted-out) projects.We could probably somewhat easily add something like an
optin_version
in the header, but that doesn't tell us exactly which projects should use that version.As it is now, we'd probably have to go through and parse all of the packages in each of the projects and find any that have a filename that includes the
patch+1
version in it.Perhaps we could also include just a list of
opted_in_projects
at the top level?We probably need to ask @DaveSys911 whether adding fields to the Ind Agent manifest would be a big issue or not.