Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsStandalone() to agent info, report management mode to gRPC #4911

Merged
merged 9 commits into from
Jun 12, 2024

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Jun 11, 2024

What does this PR do?

Note: this requires elastic/beats#39403 to work properly.

This is the second half of the changes needed for #3065.

This involves a number of small changes across a number of files, as it requires changing the AgentInfo() interface to report if the agent is running in standalone mode.

There's no tests for this yet, but you can manually test with https://github.com/elastic/mock-es/

just start the mock ES endpoint with mock-es -metrics 5s, install elastic-agent with all default settings, and check the user-agent in the reported metrics.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

@fearful-symmetry fearful-symmetry self-assigned this Jun 11, 2024
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner June 11, 2024 21:29
Copy link
Contributor

mergify bot commented Jun 11, 2024

This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jlind23 jlind23 removed the request for review from andrzej-stencel June 12, 2024 06:44
@jlind23
Copy link
Contributor

jlind23 commented Jun 12, 2024

buildkite test it

@jlind23 jlind23 enabled auto-merge (squash) June 12, 2024 06:44
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23 jlind23 merged commit 249d0b6 into elastic:main Jun 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants