-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IsStandalone()
to agent info, report management mode to gRPC
#4911
Conversation
This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
NOTE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
buildkite test it |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Quality Gate passedIssues Measures |
What does this PR do?
Note: this requires elastic/beats#39403 to work properly.
This is the second half of the changes needed for #3065.
This involves a number of small changes across a number of files, as it requires changing the
AgentInfo()
interface to report if the agent is running in standalone mode.There's no tests for this yet, but you can manually test with https://github.com/elastic/mock-es/
just start the mock ES endpoint with
mock-es -metrics 5s
, install elastic-agent with all default settings, and check the user-agent in the reported metrics.Checklist
./changelog/fragments
using the changelog tool