[8.14](backport #4910) Fix issue with log_writer panic on line with all spaces #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Fix #4907. * Add changelog. * Apply suggestions from code review Co-authored-by: Julien Lind <[email protected]> --------- Co-authored-by: Julien Lind <[email protected]> (cherry picked from commit 3df9f8b)
mergify
bot
requested review from
blakerouse and
michel-laterman
and removed request for
a team
|
blakerouse
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where the
log_writer.gocan panic in the case it hits a line that is all spaces that becomes empty.Why is it important?
Should not panic and crash.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testRelated issues
This is an automatic backport of pull request #4910 done by [Mergify](https://mergify.com).