-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade go agent to v2 #4939
Conversation
go.elastic.co/apm v1 has been deprecated for a while. Update the dependency to v2.
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
NOTE: |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request is now in conflicts. Could you fix it? 🙏
|
buildkite test it |
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, seems very mechanical change.
Quality Gate failedFailed conditions |
Force merging past the test coverage requirement. This doesn't need unit tests. |
* feat: upgrade go agent to v2 go.elastic.co/apm v1 has been deprecated for a while. Update the dependency to v2. * lint: reorder imports to fix linter issues * build: run go mod tidy * lint: remove duplicate go.mod lines * lint: keep go.elastic.co/apm version unchanged (cherry picked from commit d19603b) # Conflicts: # NOTICE.txt # go.mod # go.sum
* feat: upgrade go agent to v2 (#4939) * feat: upgrade go agent to v2 go.elastic.co/apm v1 has been deprecated for a while. Update the dependency to v2. * lint: reorder imports to fix linter issues * build: run go mod tidy * lint: remove duplicate go.mod lines * lint: keep go.elastic.co/apm version unchanged (cherry picked from commit d19603b) # Conflicts: # NOTICE.txt # go.mod # go.sum * conflicts resolved --------- Co-authored-by: kruskall <[email protected]> Co-authored-by: Michal Pristas <[email protected]>
What does this PR do?
Update the dependency to v2.
Why is it important?
go.elastic.co/apm v1 has been deprecated for a while.
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Can be dropped from the dependency graph completely once elastic/e2e-testing#3845 is merged
Questions to ask yourself
Closes #3404