Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade go agent to v2 #4939

Merged
merged 15 commits into from
Jul 9, 2024
Merged

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Jun 14, 2024

What does this PR do?

Update the dependency to v2.

Why is it important?

go.elastic.co/apm v1 has been deprecated for a while.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Can be dropped from the dependency graph completely once elastic/e2e-testing#3845 is merged

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

Closes #3404

go.elastic.co/apm v1 has been deprecated for a while. Update the dependency
to v2.
@kruskall kruskall requested a review from a team as a code owner June 14, 2024 18:21
@kruskall kruskall requested review from rdner and pchila June 14, 2024 18:21
Copy link
Contributor

mergify bot commented Jun 14, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@kruskall kruskall added the enhancement New feature or request label Jun 14, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pierrehilbert pierrehilbert requested review from blakerouse and removed request for rdner June 17, 2024 06:57
@jlind23
Copy link
Contributor

jlind23 commented Jun 18, 2024

@pchila I think this will also close #3404 right?

Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

mergify bot commented Jun 21, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b drop/old-apm-agent upstream/drop/old-apm-agent
git merge upstream/main
git push upstream drop/old-apm-agent

@jlind23
Copy link
Contributor

jlind23 commented Jun 21, 2024

buildkite test it

Copy link
Contributor

mergify bot commented Jun 21, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b drop/old-apm-agent upstream/drop/old-apm-agent
git merge upstream/main
git push upstream drop/old-apm-agent

Copy link
Contributor

mergify bot commented Jun 24, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b drop/old-apm-agent upstream/drop/old-apm-agent
git merge upstream/main
git push upstream drop/old-apm-agent

Copy link
Contributor

mergify bot commented Jul 1, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b drop/old-apm-agent upstream/drop/old-apm-agent
git merge upstream/main
git push upstream drop/old-apm-agent

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems very mechanical change.

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube

@cmacknz
Copy link
Member

cmacknz commented Jul 9, 2024

Force merging past the test coverage requirement. This doesn't need unit tests.

@cmacknz cmacknz merged commit d19603b into elastic:main Jul 9, 2024
12 of 14 checks passed
@kruskall kruskall deleted the drop/old-apm-agent branch July 9, 2024 20:23
@michalpristas michalpristas added backport-8.15 Automated backport to the 8.15 branch with mergify and removed backport-skip labels Aug 2, 2024
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
* feat: upgrade go agent to v2

go.elastic.co/apm v1 has been deprecated for a while. Update the dependency
to v2.

* lint: reorder imports to fix linter issues

* build: run go mod tidy

* lint: remove duplicate go.mod lines

* lint: keep go.elastic.co/apm version unchanged

(cherry picked from commit d19603b)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
pierrehilbert pushed a commit that referenced this pull request Aug 5, 2024
* feat: upgrade go agent to v2 (#4939)

* feat: upgrade go agent to v2

go.elastic.co/apm v1 has been deprecated for a while. Update the dependency
to v2.

* lint: reorder imports to fix linter issues

* build: run go mod tidy

* lint: remove duplicate go.mod lines

* lint: keep go.elastic.co/apm version unchanged

(cherry picked from commit d19603b)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum

* conflicts resolved

---------

Co-authored-by: kruskall <[email protected]>
Co-authored-by: Michal Pristas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.15 Automated backport to the 8.15 branch with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update elastic apm dependency to apm v2
8 participants