Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop golang.org/x/exp dependency #4940

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

kruskall
Copy link
Member

What does this PR do?

Go 1.21 added the new slices package upstream so we drop usage of x/exp and use the stdlib package.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

Go 1.21 added the new slices package upstream so we drop usage
of x/exp and use the stdlib package.
@kruskall kruskall added the enhancement New feature or request label Jun 14, 2024
@kruskall kruskall requested a review from a team as a code owner June 14, 2024 18:49
@kruskall kruskall requested review from blakerouse and pchila June 14, 2024 18:49
Copy link
Contributor

mergify bot commented Jun 14, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link

@cmacknz cmacknz merged commit baf715e into elastic:main Jun 17, 2024
13 checks passed
@kruskall kruskall deleted the drop/x-exp branch June 17, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants