-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Host Metrics receiver to OTel mode #4950
Add Host Metrics receiver to OTel mode #4950
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request does not have a backport label. Could you fix it @andrzej-stencel? 🙏
NOTE: |
The Windows startup errors are potentially due to significant delay added by the init() function in https://github.com/leoluk/perflib_exporter/blob/d0f3e166e8e144b7c5b02c55bbff65626c2077a3/perflib/perflib.go#L267. Thanks to @leehinman for spotting this. I don't think there's anything you can do in Elastic Agent to get around this, this will have to be improved or removed upstream. |
The https://github.com/leoluk/perflib_exporter repository is archived and recommends to use https://pkg.go.dev/github.com/prometheus-community/windows_exporter/pkg/perflib. This library apparently does not have the issue anymore. 🎉 prometheus-community/windows_exporter@11218a9#diff-a32807247e4aca11d44d5fefeab725bd8666039036720b9bd13ee154b19a896bL35 Let's add a replacement in go.mod and see if that helps. Simultaneously, I will push this fix in the upstream. |
Quality Gate passedIssues Measures |
This pull request is now in conflicts. Could you fix it? 🙏
|
Superseded by #4908 |
What does this PR do?
This PR makes the Host Metrics receiver available to users running Elastic Agent in
otel
mode.Why is it important?
This allows users to collect infrastructure metrics and is a prerequisite to support the infrastructure integration with OTel Collector.
Checklist
./changelog/fragments
using the changelog toolHow to test this PR locally
build/distributions
Related issues
hostmetricsreceiver
available inotel
mode #4724