Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unused Beat spec files #4964

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jun 19, 2024

Remove the Beat spec files since they have been obsoleted by the agentbeat spec file to avoid confusion over where to make changes.

The Filebeat spec file was used in several tests for creating components from complex spec files. Rather than rewrite them all, I renamed the filebeat spec file to testbeat and added a comment that it is a frozen in time 8.12.0 filebeat spec file used for testing.

@cmacknz cmacknz added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Jun 19, 2024
@cmacknz cmacknz requested a review from blakerouse June 19, 2024 21:38
@cmacknz cmacknz self-assigned this Jun 19, 2024
@cmacknz cmacknz requested a review from a team as a code owner June 19, 2024 21:38
@cmacknz cmacknz requested a review from andrzej-stencel June 19, 2024 21:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

mergify bot commented Jun 19, 2024

This pull request does not have a backport label. Could you fix it @cmacknz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cmacknz cmacknz merged commit 9bf125b into elastic:main Jun 20, 2024
16 checks passed
@cmacknz cmacknz deleted the remove-beat-spec-files branch June 20, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants