-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kubernetes Provider] Fix namespace filter on pod and service watchers #4975
Conversation
This pull request does not have a backport label. Could you fix it @constanca-m? 🙏
NOTE: |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
/test |
Quality Gate passedIssues Measures |
should this be backported to 8.14.2? |
The fix is only applied on beats for 8.15 (PR here) @michalpristas, so I am trying to fix it in the same version everywhere @michalpristas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
We really need to get integration testing for kubernetes.
@blakerouse you know if we have some backing issue for adding it? |
@michalpristas #4984 would be a first good progress here! |
What does this PR do?
The watchers now take into account the
namespace
specified by the user.Checklist
./changelog/fragments
using the changelog toolHow to test this PR locally
> EXTERNAL=true DEV=true PLATFORMS=linux/amd64 SNAPSHOT=TRUE PACKAGES=docker mage package
> kind load docker-image custom-agent-image:latest
Related issues
Relates elastic/beats#38978.