Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of artifacts-api.elastic.co and its client #5050

Conversation

rdner
Copy link
Member

@rdner rdner commented Jul 3, 2024

This includes removal of
TestStandaloneDowngradeToSpecificSnapshotBuild integration test.

Discussed with @pchila and @cmacknz

  1. Independent agent patch releases will be ready very soon.
  2. We are likely to handle downgrades in a different way than “upgrade to lower version” in the actual product.
  3. This test fails our integration tests sue to instability of artifacts-api.elastic.co and that's the only code that is still using this API.

Closes #4347

@rdner rdner added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team skip-changelog labels Jul 3, 2024
@rdner rdner requested review from cmacknz and pchila July 3, 2024 13:31
@rdner rdner self-assigned this Jul 3, 2024
@rdner rdner requested a review from a team as a code owner July 3, 2024 13:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Copy link
Contributor

mergify bot commented Jul 3, 2024

This pull request does not have a backport label. Could you fix it @rdner? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Jul 3, 2024
Copy link
Contributor

mergify bot commented Jul 3, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove-TestStandaloneDowngradeToSpecificSnapshotBuild upstream/remove-TestStandaloneDowngradeToSpecificSnapshotBuild
git merge upstream/main
git push upstream remove-TestStandaloneDowngradeToSpecificSnapshotBuild

@rdner rdner force-pushed the remove-TestStandaloneDowngradeToSpecificSnapshotBuild branch from 2a2ba2e to 899434d Compare July 3, 2024 13:59
rdner added 2 commits July 3, 2024 16:01
This includes removal of
TestStandaloneDowngradeToSpecificSnapshotBuild integration test.
@rdner rdner force-pushed the remove-TestStandaloneDowngradeToSpecificSnapshotBuild branch from 899434d to b8336a4 Compare July 3, 2024 14:08
Copy link

@rdner rdner requested a review from pchila July 3, 2024 17:22
@rdner
Copy link
Member Author

rdner commented Jul 5, 2024

@cmacknz are we still doing this?

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it, this leaves some infrequently and not critical path code without a test, but eliminates the most frequent test failure.

@rdner rdner merged commit 51edd17 into elastic:main Jul 5, 2024
13 checks passed
@rdner rdner deleted the remove-TestStandaloneDowngradeToSpecificSnapshotBuild branch July 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
4 participants