Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14](backport #5129) [CI] Separated packaging step #5143

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 16, 2024

What does this PR do?

Separated packaging step

Why is it important?

Now we don't need to re-package agent when restarting tests from BK UI

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #5129 done by [Mergify](https://mergify.com).

* [CI] Separated packaging step

* [CI] Separated packaging step

* Fix mistype

* Fix mistype

* Cleanup

* Update .buildkite/scripts/steps/integration_tests.sh

Co-authored-by: Paolo Chilà <[email protected]>

* Update .buildkite/scripts/steps/integration-package.sh

Co-authored-by: Paolo Chilà <[email protected]>

* Cleanup

---------

Co-authored-by: Paolo Chilà <[email protected]>
(cherry picked from commit 9c49b37)

# Conflicts:
#	.buildkite/scripts/steps/integration_tests.sh
@mergify mergify bot requested a review from a team as a code owner July 16, 2024 19:06
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jul 16, 2024
@mergify mergify bot requested review from michel-laterman and pchila and removed request for a team July 16, 2024 19:06
@mergify mergify bot assigned pazone Jul 16, 2024
Copy link
Contributor Author

mergify bot commented Jul 16, 2024

Cherry-pick of 9c49b37 has failed:

On branch mergify/bp/8.14/pr-5129
Your branch is up to date with 'origin/8.14'.

You are currently cherry-picking commit 9c49b37408.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .buildkite/integration.pipeline.yml
	new file:   .buildkite/scripts/steps/integration-package.sh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/scripts/steps/integration_tests.sh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@@ -11,10 +11,20 @@ MAGE_SUBTARGET="${3:-""}"
# This file is managed by an automation (mage integration:UpdateAgentPackageVersion) that check if the snapshot is ready.
OVERRIDE_AGENT_PACKAGE_VERSION="$(cat .package-version)"

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pazone same as with 8.15 backport

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor Author

mergify bot commented Jul 22, 2024

This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏

@pierrehilbert pierrehilbert requested review from pazone and removed request for michel-laterman and pchila July 22, 2024 06:07
@pazone pazone merged commit 15b68e7 into 8.14 Jul 25, 2024
13 checks passed
@pazone pazone deleted the mergify/bp/8.14/pr-5129 branch July 25, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants