Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove set -x from Buildkite scripts #5165

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Remove set -x from Buildkite scripts #5165

merged 1 commit into from
Jul 18, 2024

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

This PR removes the set -x options from two scripts run as part of "K8s tests" group in the Elastic Agent buildkite pipeline.

Why is it important?

To avoid printing out secrets.

@ycombinator ycombinator requested a review from a team as a code owner July 18, 2024 01:49
@ycombinator ycombinator requested review from blakerouse, faec, pazone, fearful-symmetry and chloeruka and removed request for blakerouse and faec July 18, 2024 01:49
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 18, 2024

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

chloeruka
chloeruka approved these changes Jul 18, 2024
View reviewed changes
Copy link

@chloeruka chloeruka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my side

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@rowlandgeoff rowlandgeoff requested a review from dliappis July 18, 2024 03:45
@rowlandgeoff rowlandgeoff mentioned this pull request Jul 18, 2024
Merged
7 tasks
@ycombinator ycombinator enabled auto-merge (squash) July 18, 2024 05:17
@ycombinator ycombinator added backport-8.15 Automated backport to the 8.15 branch with mergify and removed backport-skip labels Jul 18, 2024
@ycombinator ycombinator merged commit 6c5b7ed into elastic:main Jul 18, 2024
15 of 17 checks passed
@ycombinator ycombinator deleted the no-set-x branch July 18, 2024 06:31
mergify bot pushed a commit that referenced this pull request Jul 18, 2024
@ycombinator @mergify
Remove set -x (#5165)
55f0dc7 
(cherry picked from commit 6c5b7ed)
@mergify mergify bot mentioned this pull request Jul 18, 2024
Merged
ycombinator added a commit that referenced this pull request Jul 18, 2024
@mergify @ycombinator
Remove set -x (#5165) (#5166)
53b639f 
(cherry picked from commit 6c5b7ed)

Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowlandgeoff rowlandgeoff rowlandgeoff approved these changes

@chloeruka chloeruka chloeruka approved these changes

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@pazone pazone Awaiting requested review from pazone

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry

@dliappis dliappis Awaiting requested review from dliappis

Assignees

@ycombinator ycombinator

Labels
backport-8.15 Automated backport to the 8.15 branch with mergify skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ycombinator @pierrehilbert @chloeruka @rowlandgeoff