Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small clean up of the fleet gateway "run" function implementation #5169

Merged
merged 11 commits into from
Jul 23, 2024

Conversation

aleksmaus
Copy link
Member

What does this PR do?

Small clean up of the fleet gateway "run" function implementation

Why is it important?

Just stumbled upon this piece and I think it can be simplified, one less go routine.

Checklist

  • My code follows the style guidelines of this project

How to test this PR locally

Regression test with the fleet

@aleksmaus aleksmaus requested a review from a team as a code owner July 18, 2024 14:13
Copy link
Contributor

mergify bot commented Jul 18, 2024

This pull request does not have a backport label. Could you fix it @aleksmaus? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jul 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ycombinator ycombinator requested review from pchila and andrzej-stencel and removed request for blakerouse and pchila July 18, 2024 21:38
@aleksmaus
Copy link
Member Author

docker: Error response from daemon: Head "https://docker.elastic.co/v2/beats-dev/fpm/manifests/1.13.1": Get "https://docker-auth.elastic.co/auth?account=jenkins_ro&scope=repository%3Abeats-dev%2Ffpm%3Apull&service=token-service": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers).

sigh

@aleksmaus aleksmaus merged commit 3f363ff into elastic:main Jul 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants