-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TestEventLogFile, TestContainerCMDEventToStderr and TestEventLogOutputConfiguredViaFleet #5341
Conversation
Fix TestEventLogFile by updating the string that needs to be searched in the logs.
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request does not have a backport label. Could you fix it @belimawr? 🙏
NOTE: |
Fix TestContainerCMDEventToStderr and TestEventLogOutputConfiguredViaFleet as they were also searching for strings Beats does not log any more.
Quality Gate passedIssues Measures |
Looks like
|
I believe it failed due to the flakiness reported on #5159. I'm working on reproducing this case. |
Going to backport this PR to unblock some of the backport PRs where these tests are failing. |
Fix TestEventLogFile by updating the string that needs to be searched in the logs. (cherry picked from commit b96a4ca)
Fix TestEventLogFile by updating the string that needs to be searched in the logs. (cherry picked from commit b96a4ca) Co-authored-by: Tiago Queiroz <[email protected]>
What does this PR do?
Fix TestEventLogFile, TestContainerCMDEventToStderr and TestEventLogOutputConfiguredViaFleet by updating the string that needs to be searched in the logs.
Why is it important?
It fixes some test that were breaking CI
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in./changelog/fragments
using the changelog toolDisruptive User Impact
There is no disruptive user impact because this PR is fixing a broken test
How to test this PR locally
Package the Elastic-Agent from this PR:
Then run one of the integration test that were failing:
TestEventLogFile
,TestContainerCMDEventToStderr
orTestEventLogOutputConfiguredViaFleet
Related issues
Questions to ask yourself