-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace pkg/errors with stdlib errors #5355
Conversation
use upstream error wrapping and replace pkg/errors usage with stdlib errors. remove unused nolint comments
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
NOTE: |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Seems to be the same error as #4861 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!!! Thanks for this.
There's no "new code" 😭 |
Quality Gate failedFailed conditions |
@blakerouse sorry for the ping, can you help with this ? There's no "new code", I'm not sure why the coverage decreased 🤔 |
@kruskall Yeah I have no idea why SonarQube is so wrong here. @ycombinator @pierrehilbert Could one of you force merge this? Only thing not passing is SonarQube, for an unknown reason. |
What does this PR do?
use upstream error wrapping and replace pkg/errors usage with stdlib errors.
remove unused nolint comments
Why is it important?
https://github.com/pkg/errors is archived and it is no longer maintained
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself