Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace pkg/errors with stdlib errors #5355

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

kruskall
Copy link
Member

What does this PR do?

use upstream error wrapping and replace pkg/errors usage with stdlib errors.
remove unused nolint comments

Why is it important?

https://github.com/pkg/errors is archived and it is no longer maintained

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

use upstream error wrapping and replace pkg/errors usage with
stdlib errors.
remove unused nolint comments
@kruskall kruskall requested a review from a team as a code owner August 25, 2024 02:06
@kruskall kruskall added enhancement New feature or request skip-changelog labels Aug 25, 2024
Copy link
Contributor

mergify bot commented Aug 25, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Aug 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pierrehilbert pierrehilbert requested review from blakerouse and removed request for faec August 25, 2024 14:23
@kruskall
Copy link
Member Author

Seems to be the same error as #4861

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!!! Thanks for this.

@kruskall
Copy link
Member Author

5.9% Coverage on New Code (required ≥ 40%)

There's no "new code" 😭

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
5.9% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube

@kruskall
Copy link
Member Author

kruskall commented Sep 3, 2024

@blakerouse sorry for the ping, can you help with this ? There's no "new code", I'm not sure why the coverage decreased 🤔

@blakerouse
Copy link
Contributor

@kruskall Yeah I have no idea why SonarQube is so wrong here.

@ycombinator @pierrehilbert Could one of you force merge this? Only thing not passing is SonarQube, for an unknown reason.

@cmacknz cmacknz merged commit f904ba9 into elastic:main Sep 3, 2024
12 of 13 checks passed
@kruskall kruskall deleted the feat/drop-pkg-errors branch September 3, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants