Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5512) Update the regex used to identify release branches to include 8.x #5518

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 11, 2024

What does this PR do?

Update the regex used to identify release branches

Why is it important?

Now we have 8.x which isn't matched by the current regex

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

None

How to test this PR locally

  • run the unit tests
go test -v -run TestGetReleaseBranches ./pkg/testing/tools/git

Related issues

  • N/A

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #5512 done by [Mergify](https://mergify.com).

Now we also need to account for the 8.x branch, therefore the process to identify release branches were updated to account for the 8.x

(cherry picked from commit 34a9830)
@mergify mergify bot requested a review from a team as a code owner September 11, 2024 13:00
@mergify mergify bot added the backport label Sep 11, 2024
@mergify mergify bot requested review from andrzej-stencel and michel-laterman and removed request for a team September 11, 2024 13:00
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ycombinator ycombinator requested a review from rdner September 11, 2024 15:19
@ycombinator
Copy link
Contributor

Tests are failing CI on this PR because they are looking for a non-existent snapshot build, for example:

=== RUN   TestStandaloneUpgrade/Upgrade_8.14.4-SNAPSHOT_to_8.16.0-SNAPSHOT_(privileged)
    upgrade_standalone_test.go:68: 
        	Error Trace:	C:/Users/windows/agent/testing/integration/upgrade_standalone_test.go:68
        	            				C:/Users/windows/agent/testing/integration/upgrade_standalone_test.go:43
        	Error:      	Received unexpected error:
        	            	failed to prepare before exec: failed to find artifact URI for version 8.14.4-SNAPSHOT: failed to find snapshot information for version "8.14.4-SNAPSHOT": snapshot for version "8.14.4" not found
        	Test:       	TestStandaloneUpgrade/Upgrade_8.14.4-SNAPSHOT_to_8.16.0-SNAPSHOT_(privileged)
--- FAIL: TestStandaloneUpgrade/Upgrade_8.14.4-SNAPSHOT_to_8.16.0-SNAPSHOT_(privileged) (0.18s)

However, in order to make the tests not look for this non-existent build any more, we need to remove that version, 8.14.4-SNAPSHOT, from here (on the 8.x branch):

"8.14.4-SNAPSHOT",

That work is done by automation, which is the thing being fixed by this PR. So we have a 🐔 / 🥚 problem. As such, force merging this PR...

@ycombinator ycombinator merged commit b9f088b into 8.x Sep 11, 2024
12 of 14 checks passed
@ycombinator ycombinator deleted the mergify/bp/8.x/pr-5512 branch September 11, 2024 15:23
@ycombinator ycombinator removed the request for review from rdner September 11, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants