Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mergify: avoid label automation always #5521

Merged
merged 2 commits into from
Sep 12, 2024
Merged

mergify: avoid label automation always #5521

merged 2 commits into from
Sep 12, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 11, 2024

What does this PR do?

Allow mergify to exclude backport-8.x if backport-skip is added.

Why is it important?

Avoid labelling constantly backport-8.x for main.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v v1v self-assigned this Sep 11, 2024
@v1v v1v requested a review from a team as a code owner September 11, 2024 14:30
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@v1v v1v enabled auto-merge (squash) September 11, 2024 14:40
This was referenced Sep 11, 2024
Merged
Merged
@v1v v1v closed this Sep 11, 2024
auto-merge was automatically disabled September 11, 2024 15:20

Pull request was closed

@v1v v1v reopened this Sep 11, 2024
@v1v
Copy link
Member Author

v1v commented Sep 11, 2024

buildkite test this

@v1v v1v enabled auto-merge (squash) September 12, 2024 09:32
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jlind23 jlind23 disabled auto-merge September 12, 2024 10:34
@jlind23 jlind23 merged commit 976b647 into elastic:main Sep 12, 2024
9 of 10 checks passed
@mergify mergify bot mentioned this pull request Sep 12, 2024
Closed
6 tasks
mergify bot pushed a commit that referenced this pull request Sep 12, 2024
@v1v @mergify
mergify: avoid label automation always (#5521)
da9b483 
Force merging as tests won't pass before a 9.x release is available.

(cherry picked from commit 976b647)

# Conflicts:
#	.mergify.yml
This was referenced Sep 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@jlind23 jlind23 jlind23 approved these changes

@blakerouse blakerouse blakerouse approved these changes

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@v1v v1v

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-skip skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @blakerouse @jlind23 @swiatekm