-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x](backport #5802) proxytest: proxy HTTPS request using MITM #5867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxytest now can proxy HTTPS requests using a men in the middle (MITM) approach to allow to fully control the requests between the proxy and the target server. (cherry picked from commit ad041d4)
mergify
bot
requested review from
kaanyalti and
pchila
and removed request for
a team
October 28, 2024 15:50
AndersonQ
requested review from
AndersonQ
and removed request for
kaanyalti and
pchila
October 29, 2024 13:01
1 task
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
Quality Gate passedIssues Measures |
pierrehilbert
approved these changes
Nov 4, 2024
AndersonQ
approved these changes
Nov 4, 2024
mergify bot
added a commit
that referenced
this pull request
Nov 4, 2024
The proxytest now can proxy HTTPS requests using a men in the middle (MITM) approach to allow to fully control the requests between the proxy and the target server. (cherry picked from commit ad041d4) Co-authored-by: Anderson Queiroz <[email protected]> (cherry picked from commit ec75170)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It extends
proxytest
to support proxying HTTPS requests.Why is it important?
It'll allow us to create integration tests for mTLS scenarios
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
Run
TestRunHTTPSProxy
passing theexample
build tag and follow the instructions to perform acRUL
request using the proxytest:go test -tags example -v -run TestRunHTTPSProxy$ ./testing/proxytest
Example:
$ curl \ --proxy-cacert /tmp/TestRunHTTPSProxy3155179289/001/proxyCA.crt \ --proxy-cert /tmp/TestRunHTTPSProxy3155179289/001/clientCert.crt \ --proxy-key /tmp/TestRunHTTPSProxy3155179289/001/clientCert.key \ --cacert /tmp/TestRunHTTPSProxy3155179289/001/proxyCA.crt \ --proxy https://127.0.0.1:40241 \ https://not-a-server.co It works!
Related issues
Questions to ask yourself
This is an automatic backport of pull request #5802 done by [Mergify](https://mergify.com).