-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.16](backport #5855) [helm]: implement system integration as chart built-in #5886
Conversation
* feat: implement system integration as chart built-in * feat: restructure logs streams in system integration to allow passing user-supplied vars * doc: add an example of system integration * feat: add missing rendered file for system integration example (cherry picked from commit e6f281a) # Conflicts: # deploy/helm/elastic-agent/values.yaml
Cherry-pick of e6f281a has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@pkoutsovasilis should we wait for 8.16.0 to be released or should we merge this one right now? |
@pkoutsovasilis I let you fix the conflict as I want to be sure I won't do something bad :x |
Being completely transparent here, I am not sure 😄 My logic is that this change is not a breaking one, the helm chart is not yet released so I don't see any immediate reason to wait for 8.16.0 release. But please do correct me if I miss anything 🙂 |
Yeah, I'm OK with adding this to |
Quality Gate passedIssues Measures |
What does this PR do?
This PR introduces support for the system integration
Why is it important?
system integration is usually used in the context of k8s, thus having it as a built-in integration improves the user configuration experience
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally