Enhancement/5832 deb rpm docker tests

[kaanyalti]

• Enhancement

What does this PR do?

Adds tests validating elastic-agent upgrade command does not and should not work for deb, rpm and docker.

Why is it important?

We currently don't have any tests validating that the upgrade command does not work

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• [ ] I have added an entry in ./changelog/fragments using the changelog tool
• I have added an integration test or an E2E test

How to test this PR locally

• Build deb, rpm packages and docker images
• Run the following commands

 TEST_PACKAGES='deb' SNAPSHOT=true TEST_GROUPS="deb" TEST_PLATFORMS="linux/amd64" GOTEST_FLAGS='-test.run ^TestRestrictUpgradeDeb$' mage integration:test

 TEST_PACKAGES='rpm' SNAPSHOT=true TEST_GROUPS="rpm" TEST_PLATFORMS="linux/amd64" GOTEST_FLAGS='-test.run ^TestRestrictUpgradeRPM$' mage integration:test

K8S_VERSION=v1.31.0 TEST_INTEG_CLEAN_ON_EXIT=true INSTANCE_PROVISIONER=kind STACK_PROVISIONER=stateful TEST_PLATFORMS="kubernetes/arm64/1.31.0/<IMAGE TYPE>" SNAPSHOT=true mage integration:kubernetes

The image type can be basic, wolfi or any other listed in the test itself

Related issues

• Closes Prevent users from upgrading standalone agents in container, deb, and rpm environments #5832

[mergify]

This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

[mergify]

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

[rowlandgeoff]

Maybe mark this PR as Draft for now while you keep testing it? I really wouldn't want to accidentally commit a change where the Buildkite pipelines are all getting commented out. 😉

[rowlandgeoff]

trying to run only my test in ci

I don't think we currently have an easy mechanism of doing this. Perhaps something we can consider in the future.

[kaanyalti]

buildkite test this

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b enhancement/5832_deb-rpm-docker-tests upstream/enhancement/5832_deb-rpm-docker-tests
git merge upstream/main
git push upstream enhancement/5832_deb-rpm-docker-tests

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b enhancement/5832_deb-rpm-docker-tests upstream/enhancement/5832_deb-rpm-docker-tests
git merge upstream/main
git push upstream enhancement/5832_deb-rpm-docker-tests

[michalpristas]

the problem with integration test is that /etc/elastic-agent is kept there and new installation assumes enrolled agent.
when you run purge it will be removed and next install will work.
why purge works and uninstall does not is this sneaky condition we have here:

case "$1" in
  purge)
    rm -rf /var/lib/elastic-agent /var/log/elastic-agent /etc/elastic-agent
    ;;

  # 0 is for rpm uninstall
  upgrade|remove|failed-upgrade|abort-install|abort-upgrade|disappear|0)

what we need to do is move rm -rf /etc/elastic-agent outside of this this if statement. this can be troublesome in case of upgrades. ideally we remove not only on purge but also uninstall but not upgrade

behavior also described in PR #4334

[kaanyalti]

the problem with integration test is that /etc/elastic-agent is kept there and new installation assumes enrolled agent. when you run purge it will be removed and next install will work. why purge works and uninstall does not is this sneaky condition we have here:

case "$1" in
  purge)
    rm -rf /var/lib/elastic-agent /var/log/elastic-agent /etc/elastic-agent
    ;;

  # 0 is for rpm uninstall
  upgrade|remove|failed-upgrade|abort-install|abort-upgrade|disappear|0)

what we need to do is move rm -rf /etc/elastic-agent outside of this this if statement. this can be troublesome in case of upgrades. ideally we remove not only on purge but also uninstall but not upgrade

behavior also described in PR #4334

Based on our discussion implement manual removal of agent files during RPM clean up in the test fixture

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

[michalpristas]

i like that

[pkoutsovasilis]

LGTM. Nice work 🙂 Thanks for addressing my comment ❤️