-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s] embed hints inputs in agent container image #6381
[k8s] embed hints inputs in agent container image #6381
Conversation
b78cd45
to
9034f25
Compare
9034f25
to
a3dba7a
Compare
Quality Gate passedIssues Measures |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm also not an expert on agent packaging, so more eyes on this would be welcome.
ty both @swiatekm and @andrzej-stencel for the reviews, since you didn't spot anything major I feel we are on the right track 🙂 That said, I am gonna wait a little bit more, hopefully for a review from @blakerouse and @gizas just to make sure that there isn't something that I missed since I am relatively new to this parts of code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Determining if providers.kubernetes.hints.enabled
didn't turn out as bad as I thought it was going to.
* feat: embed hints inputs in elastic-agent container image * chore: disable lint overflow warnings (cherry picked from commit a631362) # Conflicts: # deploy/helm/elastic-agent/examples/kubernetes-hints-autodiscover/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/multiple-integrations/rendered/manifest.yaml
What does this PR do?
This PR embeds the hints-based autodiscovery templates directly into the Elastic Agent container image. These templates, previously fetched by an init container, are now included in the image under
/usr/share/elastic-agent/hints.inputs.d
. The Elastic Agent has been updated to optionally use these embedded templates based on the Kubernetes hints configuration in the user's settings. If hints-based autodiscovery is enabled, the Elastic Agent dynamically reads from the embedded templates directory, ensuring seamless integration without external dependencies.Additionally:
Why is it important?
This change improves the robustness and efficiency of Elastic Agent deployment in Kubernetes environments by:
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
This change should not cause any disruption for users. For users who enable hints-based autodiscovery, the behavior remains consistent, with improved reliability. For users who do not enable this feature, the embedded templates will remain unused, ensuring no impact on performance or functionality.
How to test this PR locally
Related issues