Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #6360) [k8s] add kubernetes hints integration tests #6387

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 18, 2024

What does this PR do?

This is the last part (I promise) of the PR series to add support for Kubernetes hints and integration tests for Redis. It introduces:

  • Additional test cases to validate agent Kubernetes hints functionality using Redis as the hints-enabled workload:
    • When hints-enabled workloads pre-exist the agent deployment.
    • When hints-enabled workloads are deployed after the agent is already running.

Why is it important?

This PR completes the Kubernetes hints-based testing and it ensures that that Kubernetes hints functionality is thoroughly tested.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an integration test or an E2E test

Disruptive User Impact

There is no expected disruption for users as this PR only extends k8s integration tests.

How to test this PR locally

mage integration:auth
PLATFORMS=linux/arm64 EXTERNAL=true SNAPSHOT=true PACKAGES=docker mage -v package 
INSTANCE_PROVISIONER=kind STACK_PROVISIONER=stateful K8S_VERSION=v1.31.1 SNAPSHOT=true mage integration:kubernetes

Related issues


This is an automatic backport of pull request #6360 done by [Mergify](https://mergify.com).

* feat: add kubernetes hints test

* feat: utilise labelselector for checking redis pods

* feat: check redis pods for correct hint annotations

(cherry picked from commit c7c5ba4)
@mergify mergify bot requested a review from a team as a code owner December 18, 2024 16:57
@mergify mergify bot added the backport label Dec 18, 2024
@mergify mergify bot requested review from swiatekm and pchila and removed request for a team December 18, 2024 16:57
Copy link

@pkoutsovasilis pkoutsovasilis merged commit 82cf689 into 8.x Dec 18, 2024
14 checks passed
@pkoutsovasilis pkoutsovasilis deleted the mergify/bp/8.x/pr-6360 branch December 18, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants