Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubernetes templates for elastic-agent [templates.d] #6402

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Update kubernetes templates for elastic-agent [templates.d] #6402

merged 1 commit into from
Dec 19, 2024
+2,263 −471

Conversation

elastic-vault-github-plugin-prod[bot]
Copy link
Contributor

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner December 19, 2024 11:10
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

This pull request does not have a backport label. Could you fix it @elastic-vault-github-plugin-prod[bot]? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 19, 2024
@swiatekm
Copy link
Contributor

This is a result of https://github.com/elastic/package-storage-infra/pull/888 and will resolve #6372. It looks like the script may not be deterministic when it comes to input ordering, we should fix that.

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

pkoutsovasilis
pkoutsovasilis approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't be 100% sure of it, but with a quick look around these seem correct. We should definitely have a deterministic input order 👍

@gizas
Copy link
Contributor

gizas commented Dec 19, 2024

a deterministic input order

I had the impression that the order of the inputs inside the manifest file of each package defines the order. Maybe we just had too much time to update them. Apart from that lgtm!

@swiatekm
Copy link
Contributor

I'll run an update again after merging this, and we'll see if there's any changes. Maybe it's the upstream packages that changed the order after all.

@swiatekm swiatekm merged commit a6e2cb1 into main Dec 19, 2024
9 of 12 checks passed
@swiatekm swiatekm deleted the update-k8s-templates-20241219111055 branch December 19, 2024 13:41
@swiatekm swiatekm mentioned this pull request Dec 19, 2024
Closed
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
@elastic-vault-github-plugin-prod @mergify
[automation] Publish kubernetes templates for elastic-agent (#6402)
577ab59 
Co-authored-by: elasticmachine <[email protected]>
(cherry picked from commit a6e2cb1)
@mergify mergify bot mentioned this pull request Dec 19, 2024
Merged
@swiatekm swiatekm added backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Dec 19, 2024
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
@elastic-vault-github-plugin-prod @mergify
[automation] Publish kubernetes templates for elastic-agent (#6402)
c608991 
Co-authored-by: elasticmachine <[email protected]>
(cherry picked from commit a6e2cb1)
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
@elastic-vault-github-plugin-prod @mergify
[automation] Publish kubernetes templates for elastic-agent (#6402)
4a3d1c8 
Co-authored-by: elasticmachine <[email protected]>
(cherry picked from commit a6e2cb1)
This was referenced Dec 19, 2024
Merged
Merged
swiatekm pushed a commit that referenced this pull request Dec 19, 2024
@mergify @elastic-vault-github-plugin-prod
[automation] Publish kubernetes templates for elastic-agent (#6402) (#…
c676a19 
…6403)

Co-authored-by: elasticmachine <[email protected]>
(cherry picked from commit a6e2cb1)

Co-authored-by: elastic-vault-github-plugin-prod[bot] <150874479+elastic-vault-github-plugin-prod[bot]@users.noreply.github.com>
swiatekm pushed a commit that referenced this pull request Dec 19, 2024
@mergify @elastic-vault-github-plugin-prod
[automation] Publish kubernetes templates for elastic-agent (#6402) (#…
0f87c8c 
…6405)

Co-authored-by: elasticmachine <[email protected]>
(cherry picked from commit a6e2cb1)

Co-authored-by: elastic-vault-github-plugin-prod[bot] <150874479+elastic-vault-github-plugin-prod[bot]@users.noreply.github.com>
swiatekm pushed a commit that referenced this pull request Dec 19, 2024
@mergify @elastic-vault-github-plugin-prod
[automation] Publish kubernetes templates for elastic-agent (#6402) (#…
9f6ef22 
…6404)

Co-authored-by: elasticmachine <[email protected]>
(cherry picked from commit a6e2cb1)

Co-authored-by: elastic-vault-github-plugin-prod[bot] <150874479+elastic-vault-github-plugin-prod[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

@gizas gizas gizas approved these changes

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees
No one assigned
Labels
automation backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swiatekm @gizas @pkoutsovasilis