Enable additional default instrumentation #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejgordon
force-pushed
the
enable-additional-instrumentation
branch
from
cf76762 to
af51cc2
Compare
stevejgordon
force-pushed
the
enable-additional-instrumentation
branch
from
a5c07de to
c11966b
Compare
stevejgordon
force-pushed
the
enable-additional-instrumentation
branch
from
4abf71b to
dbc4150
Compare
jackshirazi
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123
Enables a default set of instrumentations when using the NuGet-based install method. For auto-instrumentation, we currently only enable the instrumentations shipped in the OTel auto instrumentation zip (i.e., Not
OpenTelemetry.Instrumentation.ElasticsearchClient). We will review those once they are stable and potentially manually pull them into our customised zip files.This also extended the retries for E2E, so hopefully, they will be less brittle in CI. It also takes additional screenshots, which help verify the Apm UI during E2E tests.