Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split building and testing in workflow #179

Merged
merged 11 commits into from
Mar 25, 2024
Merged

Split building and testing in workflow #179

merged 11 commits into from
Mar 25, 2024

Conversation

JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Mar 14, 2024 •
edited
Loading

This has two benefits:

  • Allows us to easily introduce a matric-job for testing various JVM versions without always having to recompile
  • If the workflow fails, it will be immediately clear if it was due to compilation/checkStyle or tests

Preparation for #180.

@JonasKunz JonasKunz changed the title [WIP] Split building and testing in workflow Split building and testing in workflow Mar 25, 2024
@JonasKunz JonasKunz marked this pull request as ready for review March 25, 2024 08:13
@JonasKunz JonasKunz requested review from a team March 25, 2024 08:13
v1v
v1v approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just a minor nit

.github/workflows/build.yml Outdated Show resolved Hide resolved
@JonasKunz JonasKunz merged commit 46a7609 into elastic:main Mar 25, 2024
5 checks passed
@JonasKunz JonasKunz deleted the split-build-and-test-jobs branch March 25, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v approved these changes

@SylvainJuge SylvainJuge SylvainJuge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonasKunz @SylvainJuge @v1v