Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix update script regex #183

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix update script regex #183

merged 1 commit into from
Mar 25, 2024

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Mar 14, 2024 •
edited
Loading

Fix regex for mac.

Needs validation from @JonasKunz on a mac.

@SylvainJuge SylvainJuge mentioned this pull request Mar 14, 2024
Merged
@SylvainJuge SylvainJuge requested a review from JonasKunz March 14, 2024 16:53
@SylvainJuge SylvainJuge marked this pull request as ready for review March 18, 2024 09:38
JonasKunz
JonasKunz approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@JonasKunz JonasKunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it manually, works as expected.

@SylvainJuge SylvainJuge merged commit cae99b6 into elastic:main Mar 25, 2024
4 checks passed
@SylvainJuge SylvainJuge deleted the upstream-update2 branch March 25, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasKunz JonasKunz JonasKunz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SylvainJuge @JonasKunz