Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Prepare docs #328
[docs] Prepare docs #328
Changes from 4 commits
9b38831
e44e2a2
24a80bb
ca8fc23
ce09010
0ad5009
bcd7053
16435f0
df5d7d2
b448968
22c264d
597a8a1
a7bea62
907bf1d
c0b561c
14028dc
be1578a
c651698
5118a24
0e35f17
e181c25
59685f5
7b4daff
603fdd3
b524161
08fbe23
419d641
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section needs to be the same as the content for OTEL_EXPORTER_OTLP_HEADERS in https://www.elastic.co/guide/en/observability/current/apm-open-telemetry-direct.html#apm-instrument-apps-otel
It will be the same for all agents. Maybe it can be a generic doc fragment that gets included in each agent doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be generic to all agents. Basically open the APM UI and look at the services listed to find your service. We probably have this in a dozen places in the docs, so maybe we should have this centralized somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can link to a more actionable page (or pages). This link kinda drops the user at a useless landing page with generic info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I was thinking of linking to a page related to the APM UI, but we'll need to merge elastic/observability-docs#3723 first.