Update upstream agent #49
Conversation
| @@ -15,3 +17,10 @@ updates: | |||
| github-actions: | |||
| patterns: | |||
| - "*" | |||
|
|
|||
| # Gradle | |||
| - package-ecosystem: "gradle" | |||
There was a problem hiding this comment.
[for reviewer] this configures dependabot to attempt updating gradle dependencies in gradle/libs.versions.toml, maybe other files are covered as well (but this will be the central place where we attempt to configure dependencies in the future).
|
|
||
| # Gradle | ||
| - package-ecosystem: "gradle" | ||
| directory: "/gradle/" # for now only on the version catalog to prevent noise |
There was a problem hiding this comment.
[for reviewer] for now we only try to update versions set in "version catalog", covering all dependencies should be part of #8
| @@ -16,8 +16,8 @@ subprojects { | |||
| ext { | |||
| deps = [ | |||
| autoservice: [ | |||
| "com.google.auto.service:auto-service:" + libraries.versions.autoservice.get(), | |||
| "com.google.auto.service:auto-service-annotations:" + libraries.versions.autoservice.get(), | |||
| "com.google.auto.service:auto-service:" + catalog.versions.autoservice.get(), | |||
There was a problem hiding this comment.
I guess we can't use libraries instead of versions here?
There was a problem hiding this comment.
I don't know yet for those and plan to tackle it with #8 later to focus on the otel parts.
|
|
||
| testImplementation("org.mockito:mockito-core:5.5.0") | ||
|
|
||
| testImplementation(enforcedPlatform("org.junit:junit-bom:" + libraries.versions.junit.get().toString())) | ||
| testImplementation(enforcedPlatform("org.junit:junit-bom:" + catalog.versions.junit.get().toString())) |
There was a problem hiding this comment.
Same here: Impossible to use a library instead of version, correct?
There was a problem hiding this comment.
No, here it's possible to use the catalog in a declarative way, but I will do that when dealing with #8 to keep changes minimal here.
Closes #15